Skip to content

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Jan 16, 2020

No description provided.

@matklad
Copy link
Contributor Author

matklad commented Jan 16, 2020

bors r+
🤖

bors bot added a commit that referenced this pull request Jan 16, 2020
2861: Micro-optimize type hints to avoid allocations r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@kiljacken
Copy link
Contributor

I wish we had stable generators already :(

@matklad
Copy link
Contributor Author

matklad commented Jan 16, 2020

FWIW, in IntelliJ Rust I've once explicitly removed lazy sequence based processesing to an accamulator one -- the stack traces are so much nicer that way.

@kiljacken
Copy link
Contributor

@matklad I could see that being the case, but it seems like it could be solved tecnically :) I grew up with Python, so generator pipelines will always be near to my heart.
Nice change anyways, eliminating wasteful allocations is always nice!

@bors
Copy link
Contributor

bors bot commented Jan 16, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • TypeScript

@bors bors bot merged commit 272f6df into rust-lang:master Jan 16, 2020
@matklad matklad deleted the opt branch January 16, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants