Some improvements to rollup and ts config #3641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh, we had some bad experience with that typescript plugin. I am not sure we should use it... |
Veetaha
reviewed
Mar 18, 2020
matklad
reviewed
Mar 18, 2020
Author
|
Okay, I can remove the use of |
matklad
reviewed
Mar 19, 2020
| "compilerOptions": { | ||
| "module": "commonjs", | ||
| "target": "es2018", | ||
| "target": "es2019", |
Contributor
There was a problem hiding this comment.
Where do I look which es version is supported on node which is shipped with VS Code? Like, how can I check what's the highest target we can use here?
Member
There was a problem hiding this comment.
It doesn't seem clear-cut, but https://node.green/#ES2019.
Author
There was a problem hiding this comment.
@matklad for reference, this is the table I was looking at: https://kangax.github.io/compat-table/es2016plus/#chrome78. You will have to "show obsolete platforms" checkbox in the top left.
Contributor
|
bors r+ Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.