Skip to content

Some improvements to rollup and ts config #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Some improvements to rollup and ts config #3641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec2023
Add typing annotations for rollup config
darinmorrison Mar 18, 2020
630888d
Target es2019 (code 1.43 uses chromium 78)
darinmorrison Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions editors/code/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
// @ts-check

import resolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import nodeBuiltins from 'builtin-modules';

/** @type { import('rollup').RollupOptions } */
export default {
input: 'out/main.js',
plugins: [
Expand Down
2 changes: 1 addition & 1 deletion editors/code/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"target": "es2018",
"target": "es2019",
Copy link
Contributor

@matklad matklad Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do I look which es version is supported on node which is shipped with VS Code? Like, how can I check what's the highest target we can use here?

Copy link
Member

@lnicola lnicola Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem clear-cut, but https://node.green/#ES2019.

Copy link
Author

@silvanshade silvanshade Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matklad for reference, this is the table I was looking at: https://kangax.github.io/compat-table/es2016plus/#chrome78. You will have to "show obsolete platforms" checkbox in the top left.

"outDir": "out",
"lib": [
"es2019"
Expand Down