Skip to content

Conversation

@CAD97
Copy link
Contributor

@CAD97 CAD97 commented Mar 18, 2020

Closes #3644 as well.

Would setting up dependabot make sense for this repository?

@kjeremy
Copy link
Contributor

kjeremy commented Mar 18, 2020

Wait what happened here? Most of these changes are also in #3616

@CAD97
Copy link
Contributor Author

CAD97 commented Mar 18, 2020

hmm did I do this on an outdated master...

I'm surprised this is considered a clean merge.

@CAD97 CAD97 closed this Mar 18, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 18, 2020

I hate that git tells you that you're up to date with upstream/master when you aren't because you haven't done a fetch.

@CAD97 CAD97 reopened this Mar 18, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 18, 2020

Now this should properly be against master.

@matklad
Copy link
Contributor

matklad commented Mar 18, 2020

dependabot

Probably not, I feel like I’ll spend more time on it than if I just bump deps myself occasionally.

bors r+

@kjeremy
Copy link
Contributor

kjeremy commented Mar 18, 2020

@CAD97 since thin-dst is deprecated should we move to slice-dst?

@bors
Copy link
Contributor

bors bot commented Mar 18, 2020

@bors bors bot merged commit 21a35b4 into rust-lang:master Mar 18, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 18, 2020

@CAD97 since thin-dst is deprecated should we move to slice-dst?

Eventually, definitely. It's still perfectly workable for what it does, though. I think the work to rejig rowan's current API to use slice-dst and erasable rather than thin-dst is probably more work than it's worth right now, though, especially with my work towards a newly rewritten version of rowan that actually takes full advantage of slice-dst and the rest of pointer-utils. (I'd still be happy to review/mentor if someone wanted to do it, though. I considered rewriting thin-dst to use slice-dst under the covers, but I don't know if it's worth it (and having two separate impls does have some value).)

@CAD97 CAD97 deleted the cargo-update branch March 18, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants