Remove old syntax highlighting #3820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Build succeeded |
Closed
Contributor
|
What happen to guys like me that doesn't run VSCode insider? |
Contributor
Author
|
You need to wait until this feature stabilizes in VS code. Maintaining our own ad-hock hacky workarounds is costly, with our resources, the more prudent approach is to spend efforts test-driving the proposed official API. |
Contributor
|
Sorry I was not clear enough in my question: do we still have syntax highlighting with VSCode stable? :) I understand why you're doing this and I think it's the correct move. |
Contributor
Author
|
you still have the old text-mate based syntax highlighting, only the semantic bits (like underlining the mut variables) are gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
🤖