Switch to Chalk recursive solver #3990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ various fixes related to that.
Contributor
|
bors r+ Might be a good idea to run through issues linked to #2603 and add tests |
Contributor
|
Build succeeded: |
flodiebold
commented
Apr 16, 2020
| } | ||
|
|
||
| #[test] | ||
| fn proc_macro_server_types() { |
Member
Author
There was a problem hiding this comment.
ah btw this is code from RA that isn't working yet; even though we seem to be able to expand the macro, if I write the traits without macros I can't reproduce the problem. So it might be some macro issue, I'm not sure. cc @edwin0cheng
Contributor
There was a problem hiding this comment.
I just checked, it is due to the fact that we still not support mbe in trait items yet :) I opened #4039 to track the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
On the other hand,
I think part of this just comes from the fact that we're inferring more types now; but apart from that, it should be possible to improve the performance a bunch, and I'll make looking into that a priority.