Don't release uncompressed binaries under the new naming scheme #7011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matklad
reviewed
Dec 23, 2020
| - name: Nightly analysis-stats check | ||
| if: github.ref != 'refs/heads/release' | ||
| run: ./dist/rust-analyzer-x86_64-unknown-linux-gnu analysis-stats . | ||
| run: target/x86_64-unknown-linux-gnu/release/rust-analyzer analysis-stats . |
Contributor
There was a problem hiding this comment.
Couple of drive-bys:
- the
./distwas intentional here, to make sure that the final thing works. Arguably, the stats job should even download it from GitHub releases page... But this is minor, really - Let's set
RA_TARGETenv var on the job level, if possible?
Member
Author
There was a problem hiding this comment.
the ./dist was intentional here, to make sure that the final thing works. Arguably, the stats job should even download it from GitHub releases page... But this is minor, really
Yeah, but that file no longer exists (since the binary is compressed). We could gunzip it, but I'm not sure it matters too much.
Let's set RA_TARGET env var on the job level, if possible?
Sure
Contributor
There was a problem hiding this comment.
ahhh, right, yeah, makes sense!
Member
Author
There was a problem hiding this comment.
ahhh, right, yeah, makes sense!
Ask me how I found out 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+