Skip to content

Don't release uncompressed binaries under the new naming scheme #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Don't release uncompressed binaries under the new naming scheme #7011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:

- name: Nightly analysis-stats check
if: github.ref != 'refs/heads/release'
run: ./dist/rust-analyzer-x86_64-unknown-linux-gnu analysis-stats .
run: target/x86_64-unknown-linux-gnu/release/rust-analyzer analysis-stats .
Copy link
Contributor

@matklad matklad Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of drive-bys:

  • the ./dist was intentional here, to make sure that the final thing works. Arguably, the stats job should even download it from GitHub releases page... But this is minor, really
  • Let's set RA_TARGET env var on the job level, if possible?

Copy link
Member Author

@lnicola lnicola Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ./dist was intentional here, to make sure that the final thing works. Arguably, the stats job should even download it from GitHub releases page... But this is minor, really

Yeah, but that file no longer exists (since the binary is compressed). We could gunzip it, but I'm not sure it matters too much.

Let's set RA_TARGET env var on the job level, if possible?

Sure

Copy link
Contributor

@matklad matklad Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, right, yeah, makes sense!

Copy link
Member Author

@lnicola lnicola Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, right, yeah, makes sense!

Ask me how I found out 😄


- name: Upload artifacts
uses: actions/upload-artifact@v1
Expand Down
1 change: 0 additions & 1 deletion xtask/src/dist.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ fn dist_server() -> Result<()> {
let src =
Path::new("target").join(&target).join("release").join(format!("rust-analyzer{}", suffix));
let dst = Path::new("dist").join(format!("rust-analyzer-{}{}", target, suffix));
cp(&src, &dst)?;
gzip(&src, &dst.with_extension("gz"))?;

// FIXME: the old names are temporarily kept for client compatibility, but they should be removed
Expand Down