Skip to content

Spaces in depfiles are not escaped #2504

@danakj

Description

@danakj

Target names and paths in depfile can have spaces in them, and if they are not escaped then the depfile is not parsed correctly. See ninja-build/ninja#168 for ninja supporting the escaping in depfiles.

This bug causes build failures in Chromium on Windows, for paths such as ../../third_party/depot_tools/win_toolchain/vs_files/27370823e7\Windows Kits\10\Include\10.0.22621.0\shared\winapifamily.h as the path to the header file includes a space.

This can be resolved by escaping all spaces as \ .

PR #2503 can resolve this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions