feat(manual_assert_eq): new lint #16025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
needs-fcp
S-waiting-on-review
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
ada4a
force-pushed
the
manual_assert_eq
branch
from
be6ca8c to
4db706b
Compare
|
Lintcheck changes for 6b87ed6
This comment will be updated if you push new changes |
ada4a
force-pushed
the
manual_assert_eq
branch
5 times, most recently
from
5856d0e to
7ae07b6
Compare
samueltardieu
requested changes
Nov 5, 2025
clippy_lints/src/manual_assert_eq.rs
Outdated
Comment on lines
42
to
43
| && let macro_name = cx.tcx.item_name(macro_call.def_id) | ||
| && matches!(macro_name, sym::assert | sym::debug_assert) |
There was a problem hiding this comment.
Why not use this?
Suggested change
| && let macro_name = cx.tcx.item_name(macro_call.def_id) | |
| && matches!(macro_name, sym::assert | sym::debug_assert) | |
| && let Some(macro_name) = cx.tcx.get_diagnostic_name(macro_call.def_id) | |
| && matches!(macro_name, sym::assert_macro | sym::debug_assert_macro) |
There was a problem hiding this comment.
That's what the original PR used, and I wasn't sure whether there was substantial difference between the two methods. But looking at its definition, item_name does seem to be more expensive.
Changed it
rustbot
added
S-waiting-on-author
ada4a
force-pushed
the
manual_assert_eq
branch
from
7ae07b6 to
6b87ed6
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13252
Resurrection of #13333
changelog: [
manual_assert_eq]: new lint