Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 9, 2025

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Jarcho
Copy link
Contributor

Jarcho commented Nov 12, 2025

I have to question why this needs two different messages. Just "unchecked subtraction of a Duration" is enough to get the point across. Whether the lhs is a Duration or an Instant is immaterial to issue at hand (the subtraction can panic).

@ada4a
Copy link
Contributor Author

ada4a commented Nov 15, 2025

Fair point -- opened a v2 at #16097

@ada4a ada4a closed this Nov 15, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 15, 2025
@ada4a ada4a deleted the time_subtraction branch November 15, 2025 07:32
github-merge-queue bot pushed a commit that referenced this pull request Nov 16, 2025
…tion` and `Duration - Duration` (#16097)

Supersedes #16057

changelog: [`time_subtraction`]: give the same message for `Instant -
Duration` and `Duration - Duration`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants