Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Nov 15, 2025

Supersedes #16057

changelog: [time_subtraction]: give the same message for Instant - Duration and Duration - Duration

…ration_sugg`

This doesn't change any functionality, but will make it easier to switch
to a uniform message in the next commit. Also a nice simplification imo
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
Copy link
Contributor Author

ada4a commented Nov 15, 2025

Oops, forgot to r? @Jarcho

Sorry for the noise @llogiq

@rustbot rustbot assigned Jarcho and unassigned llogiq Nov 15, 2025
@github-actions
Copy link

Lintcheck changes for 32f5ae1

Lint Added Removed Changed
clippy::unchecked_time_subtraction 0 0 7

This comment will be updated if you push new changes

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarcho Jarcho added this pull request to the merge queue Nov 16, 2025
Merged via the queue into rust-lang:master with commit 63c7197 Nov 16, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 16, 2025
@ada4a ada4a deleted the time_subtraction-2 branch November 17, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants