Skip to content

Also ignore cases with comments in let_and_return #16461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samueltardieu merged 1 commit into from
Jan 25, 2026
Merged

Also ignore cases with comments in let_and_return #16461

samueltardieu merged 1 commit into from
Jan 25, 2026
+25 −1

Conversation

@Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Jan 25, 2026

Related to the example in #16451 but doesn't fix the issue itself

changelog: [let_and_return]: No longer lints when there's a comment between the let and return

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@samueltardieu samueltardieu added this pull request to the merge queue Jan 25, 2026
Merged via the queue into rust-lang:master with commit 7ffda53 Jan 25, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 25, 2026
@Alexendoo Alexendoo deleted the let-and-return-comments branch January 26, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dswij dswij

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alexendoo @rustbot @samueltardieu @dswij