Skip to content

Fix: lint groups priority comma#16813

Open
Shivangisharma4 wants to merge 1 commit intorust-lang:masterfrom
Shivangisharma4:fix/lint-groups-priority-comma
Open

Fix: lint groups priority comma#16813
Shivangisharma4 wants to merge 1 commit intorust-lang:masterfrom
Shivangisharma4:fix/lint-groups-priority-comma

Conversation

@Shivangisharma4
Copy link
Copy Markdown

@Shivangisharma4 Shivangisharma4 commented Apr 4, 2026

fixes #16812

Adding a missing comma to the diagnostic suggestion text of the lint_groups_priority lint to fix grammatically phrasing.

changelog: [lint_groups_priority]: Fixed missing comma in diagnostic suggestion text.

Copilot AI review requested due to automatic review settings April 4, 2026 17:03
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 4, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@Shivangisharma4 Shivangisharma4 changed the title Fix/lint groups priority comma Fix: lint groups priority comma Apr 4, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Clippy diagnostics and UI test expectations. While the PR description focuses on fixing a grammatical issue in the lint_groups_priority suggestion text, the diff also includes a behavioral change to the redundant_closure_for_method_calls lint in eta_reduction.

Changes:

  • Add a missing comma in the lint_groups_priority diagnostic suggestion text.
  • Update the corresponding ui-cargo/lint_groups_priority .stderr expectations.
  • Suppress redundant_closure_for_method_calls suggestions when the method comes from an “ambiguous” crate name (multiple loaded crates with the same name).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
clippy_lints/src/cargo/lint_groups_priority.rs Adds a comma to improve readability of the diagnostic suggestion text.
tests/ui-cargo/lint_groups_priority/fail/Cargo.stderr Updates blessed UI output for the changed suggestion text (and includes additional snippet-line changes).
clippy_lints/src/eta_reduction.rs Adds a guard to avoid emitting potentially-breaking suggestions in multi-version (“diamond dependency”) scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

View changes since this review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Lintcheck changes for d9cabe2

Lint Added Removed Changed
clippy::lint_groups_priority 0 0 6

This comment will be updated if you push new changes

@Shivangisharma4 Shivangisharma4 force-pushed the fix/lint-groups-priority-comma branch from 4a1701f to d9cabe2 Compare April 4, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix grammatical error in lint_groups_priority diagnostic suggestion

4 participants