Fix: lint groups priority comma#16813
Fix: lint groups priority comma#16813Shivangisharma4 wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
Pull request overview
This PR updates Clippy diagnostics and UI test expectations. While the PR description focuses on fixing a grammatical issue in the lint_groups_priority suggestion text, the diff also includes a behavioral change to the redundant_closure_for_method_calls lint in eta_reduction.
Changes:
- Add a missing comma in the
lint_groups_prioritydiagnostic suggestion text. - Update the corresponding
ui-cargo/lint_groups_priority.stderrexpectations. - Suppress
redundant_closure_for_method_callssuggestions when the method comes from an “ambiguous” crate name (multiple loaded crates with the same name).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
clippy_lints/src/cargo/lint_groups_priority.rs |
Adds a comma to improve readability of the diagnostic suggestion text. |
tests/ui-cargo/lint_groups_priority/fail/Cargo.stderr |
Updates blessed UI output for the changed suggestion text (and includes additional snippet-line changes). |
clippy_lints/src/eta_reduction.rs |
Adds a guard to avoid emitting potentially-breaking suggestions in multi-version (“diamond dependency”) scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Lintcheck changes for d9cabe2
This comment will be updated if you push new changes |
4a1701f to
d9cabe2
Compare
fixes #16812
Adding a missing comma to the diagnostic suggestion text of the
lint_groups_prioritylint to fix grammatically phrasing.changelog: [
lint_groups_priority]: Fixed missing comma in diagnostic suggestion text.