Extend zst_offset lint to detect NonNull<T> offset calculations#16888
Open
Gri-ffin wants to merge 1 commit intorust-lang:masterfrom
Open
Extend zst_offset lint to detect NonNull<T> offset calculations#16888Gri-ffin wants to merge 1 commit intorust-lang:masterfrom
zst_offset lint to detect NonNull<T> offset calculations#16888Gri-ffin wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16887
The
zst_offsetlint previously only checked raw pointers (*mut T/*const T) for offset calculations on zero-sized types.NonNull<T>also providesadd,sub, andoffsetmethods that are equally no-ops on ZSTs, but were not flagged.The PR extends the lint to also check
NonNull<T>receivers.changelog: [
zst_offset]: detect zero-sizedNonNull<T>offset calculations.