fix: [needless_return_with_question_mark] trigger in async functions

[Gri-ffin]

fixes #16950

lint should now also trigger over async fns.

changelog: [needless_return_with_question_mark]: fix false negative in async fn bodies.

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq

[github-actions]

Lintcheck changes for 7db6bf7

Lint	Added	Removed	Changed
clippy::needless_return_with_question_mark	2	0	0

This comment will be updated if you push new changes

[samueltardieu]

This should cover async blocks as well:

async fn async_block() -> Result<(), ()> {
    async {
        return Err(())?;
    }
    .await
}

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Gri-ffin]

@rustbot ready

I added async blocks tests.