replace after-operator with check for type declaration syntax #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dten
force-pushed
the
macro-syntax-improve
branch
2 times, most recently
from
bff9204 to
871021d
Compare
Author
|
this is rebased over #220 |
the after-operator was to deal with type declarations of the style used in `forward_ref_binop` which contains `type Output = <$t as $imp<$u>>::Output;` there is a more precise way to deal with this and it fixes other macro syntax highlighting such as in mdo (although it uses a custom operator so all bets are off)
dten
force-pushed
the
macro-syntax-improve
branch
from
871021d to
3e6ebe5
Compare
urschrei
pushed a commit
to urschrei/sublime-rust
that referenced
this pull request
Jan 30, 2018
…ang#221) * handle comments around parameters and types in general * replace after-operator with check for type declaration syntax the after-operator was to deal with type declarations of the style used in `forward_ref_binop` which contains `type Output = <$t as $imp<$u>>::Output;` there is a more precise way to deal with this and it fixes other macro syntax highlighting such as in mdo (although it uses a custom operator so all bets are off)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the after-operator was to deal with type declarations of the style used in
forward_ref_binopwhich containstype Output = <$t as $imp<$u>>::Output;there is a more precise way to deal with this and it fixes other macro syntax highlighting such as in mdo (although it uses a custom operator so all bets are off)
fixes #219 a
