Remove print/eprint snippet. #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the print! and eprint! snippets. They are used much less often (about 5% of the time on crates.io), and often get in the way of wanting to complete the `ln` versions. Snippets aren't really a replacement for full completion, and I think should be reserved for common templates. If the user really wants the non-`ln` version, they can just type it manually, or delete the `ln` after completion. If the user really wants these snippets, they can be added back into their User directory.
Closed
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 29, 2019
382: Remove print/eprint snippet. r=ehuss a=ehuss This removes the print! and eprint! snippets. They are used much less often (about 5% of the time on crates.io), and often get in the way of wanting to complete the `ln` versions. Snippets aren't really a replacement for full completion, and I think should be reserved for common templates. If the user really wants the non-`ln` version, they can just type it manually, or delete the `ln` after completion. If the user really wants these snippets, they can be added back into their User directory. Closes #375. Co-authored-by: Eric Huss <eric@huss.org>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the print! and eprint! snippets. They are used much less often
(about 5% of the time on crates.io), and often get in the way of wanting to
complete the
lnversions. Snippets aren't really a replacement for fullcompletion, and I think should be reserved for common templates. If the user
really wants the non-
lnversion, they can just type it manually, or deletethe
lnafter completion. If the user really wants these snippets, theycan be added back into their User directory.
Closes #375.