Next/prev jump to end of span. #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the next/prev commands to jump to the end of a message span instead of the beginning. When using inline phantoms, jumping to the beginning can be hard to see the message for a multi-line message. I've flip-flopped over time which I like better. I've been using "end" for a while now, and it seems to work better for me. If anyone objects, we can always add a config setting. This also changes how the test works, since the old test didn't handle this new format very well.
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
397: Next/prev jump to end of span. r=ehuss a=ehuss This changes the next/prev commands to jump to the end of a message span instead of the beginning. When using inline phantoms, jumping to the beginning can be hard to see the message for a multi-line message. I've flip-flopped over time which I like better. I've been using "end" for a while now, and it seems to work better for me. If anyone objects, we can always add a config setting. This also changes how the test works, since the old test didn't handle this new format very well. Co-authored-by: Eric Huss <eric@huss.org>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the next/prev commands to jump to the end of a message span instead
of the beginning. When using inline phantoms, jumping to the beginning can
be hard to see the message for a multi-line message.
I've flip-flopped over time which I like better. I've been using "end" for a
while now, and it seems to work better for me. If anyone objects, we can always
add a config setting.
This also changes how the test works, since the old test didn't handle this new
format very well.