update some triage steps, remove requires-incomplete-features
#986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Dylan-DPC rustbot has assigned @Dylan-DPC. Use |
jieyouxu
reviewed
Dec 15, 2025
| - Add `A-*` labels based on the code that causes the issue (check backtraces!), and the nature of the repro (e.g. if the repro is a weird trait impl or the backtrace points to `rustc_trait_selection`, add `A-traits`). | ||
| - Add `T-*`, `WG-*`, `PG-*`, `F-*`, `requires-*`, and `regression-*` labels as appropriate. | ||
| - Usually the ICE should be tagged `T-compiler`. If the issue concerns the type system (e.g. trait solver), also tag the issue with `T-types`. | ||
| - If it is an ICE in rustdoc, add `T-rustdoc` instead of `T-compiler`. |
Member
There was a problem hiding this comment.
Remark: there's a bit of nuance here, in that rustdoc is a rustc_private tool, which means that a root cause can be from the rustc frontend bits. But yes, I agree this is a better label in the general case, at worst the compiler label can be reapplied or adjusted.
Member
|
Took the liberty to push a commit to clarify the bisection/MCVE label flips, but otherwise looks good. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the feedback from https://rust-lang.zulipchat.com/#narrow/channel/242269-t-release.2Ftriage/topic/Deleting.20unnecessary.20labels and some other small tweaks.
Rendered