Skip to content

Commit cd6c17e

Browse files
authored
Rollup merge of #149525 - RalfJung:debuginfo-test-comments, r=jieyouxu
debuginfo/macro-stepping test: extend comments Those `#locN` markers look like they are debuginfo compiletest magic (since `#break` is debuginfo compiletest magic). However, they are actually just magic strings used by the `check` commands in the test itself. This threw me off when I looked at the test (prompted by a CI failure), so let's leave a comment for the next poor soul that ends up lost in this test. Also, for some reason the lldb instructions do not check for `#loc6`, unlike the gdb instructions. I do not know of an lldb version that actually makes the test pass (do we even run it with lldb at all on CI?), so I won't try to add a check for loc6, but let's at least add a comment to increase the chance that someone more knowledgeable about lldb and our test suite notices this in the future.
2 parents 5afd8ff + 18af84b commit cd6c17e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tests/debuginfo/macro-stepping.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
//! This tests that `next` skips over macro invocations correctly.
2+
//! The `#locN` markers have no meaning for compiletest, we include them just
3+
//! so that the debugger prints them when printing the current source location,
4+
//! and we can match on them for testing purposes.
5+
16
//@ ignore-android
27
//@ min-lldb-version: 1800
38
//@ min-gdb-version: 13.0
@@ -68,6 +73,7 @@ extern crate macro_stepping; // exports new_scope!()
6873
//@ lldb-command:next
6974
//@ lldb-command:frame select
7075
//@ lldb-check:[...] #loc5 [...]
76+
// FIXME: what about loc6?
7177

7278
//@ lldb-command:continue
7379
//@ lldb-command:step

0 commit comments

Comments
 (0)