-
Notifications
You must be signed in to change notification settings - Fork 14.1k
refactor: remove Ord bound from BinaryHeap::new etc #149408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
This seems fine to me but will need libs-api FCP. |
|
Thanks! Is that this? https://rustc-dev-guide.rust-lang.org/stability.html#stabilizing-a-library-feature What actions can I take to progress this :) Sorry I've not made changes to std before! |
|
No action needed on your end :) the label I added means it will get discussed at this week’s meeting. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@rfcbot merge libs-api |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This adds consistency with e.g
BTreeMap::new, and makes it easier to e.g#[derive(Default)]1Footnotes
https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f848e472a176fae155f17455bdfe0aee ↩