-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Closed as duplicate of#125654
Copy link
Labels
A-metaArea: Issues & PRs about the rust-lang/rust repository itselfArea: Issues & PRs about the rust-lang/rust repository itselfC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
The git pre-push hook does not check whether there are uncommitted changes in the repo or not. It probably should.
I discovered this after running git commit --amend but forgetting to actually git add the changed files. I then did a git push --force-with-lease. The pre-push hook then ran checks on the uncommitted files, found no issues, and then proceeded to allow me to push the commited files, which were different from the files that the pre-push hook checks. The pushed files failed the tidy check on github actions.
Metadata
Metadata
Assignees
Labels
A-metaArea: Issues & PRs about the rust-lang/rust repository itselfArea: Issues & PRs about the rust-lang/rust repository itselfC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)