Skip to content

style-guide: Add try blocks#152311

Open
ia0 wants to merge 2 commits intorust-lang:mainfrom
ia0:style
Open

style-guide: Add try blocks#152311
ia0 wants to merge 2 commits intorust-lang:mainfrom
ia0:style

Conversation

@ia0
Copy link
Contributor

@ia0 ia0 commented Feb 7, 2026

The tracking issue for try_blocks is #31436.
The tracking issue for try_blocks_heterogeneous is #149488.

I'm not sure if this should be in nightly.md instead.

See #t-lang > try blocks @ 💬 for context.

Also there doesn't seem to be any style guide about "overflowed expressions". If there were, then any decision on rust-lang/rustfmt#6799 would be relevant to document.

@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Feb 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

r? @calebcartwright

rustbot has assigned @calebcartwright.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: style-team
  • style-team expanded to calebcartwright, joshtriplett, traviscross
  • Random selection from calebcartwright, traviscross

@ia0
Copy link
Contributor Author

ia0 commented Feb 17, 2026

@rustbot label +I-style-nominated

Nominating as per requested in #149488 (comment)

@rustbot rustbot added the I-style-nominated Nominated for discussion during a style team meeting. label Feb 17, 2026
@traviscross traviscross added I-lang-radar Items that are on lang's radar and will need eventual work or consideration. and removed I-style-nominated Nominated for discussion during a style team meeting. labels Mar 3, 2026
@joshtriplett
Copy link
Member

This now looks right to me, and I'd be happy to see it merged, modulo that we need to figure out how to handle unstable bits (or wait for it to be stabilized with a final syntax).

@joshtriplett joshtriplett added the I-style-nominated Nominated for discussion during a style team meeting. label Mar 4, 2026
@joshtriplett
Copy link
Member

@rfcbot merge style
@rfcbot concern wait-for-final-syntax-or-handle-as-nightly

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Mar 4, 2026

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 4, 2026
@joshtriplett
Copy link
Member

We should also respond to rust-lang/rustfmt#6799 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. I-style-nominated Nominated for discussion during a style team meeting. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants