-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: ayu code color selector more specific #100960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Aug 24, 2022
A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha Some changes occurred in HTML/CSS themes. |
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 24, 2022
Sorry, I misunderstood what you meant. This rule specifically is for item information, not search results. |
According to #100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.
notriddle
force-pushed
the
notriddle/ayu-span-code
branch
from
August 24, 2022 17:41
30e2995
to
5bac3d7
Compare
GuillaumeGomez
approved these changes
Aug 24, 2022
Thanks! r=me once CI pass |
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 24, 2022
@bors rollup |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 24, 2022
… r=GuillaumeGomez rustdoc: ayu code color selector more specific According to rust-lang#100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.
This was referenced Aug 24, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`) - rust-lang#99954 (let-else: break out to one scope higher for let-else) - rust-lang#100188 (Parser will not suggest invalid expression when use public) - rust-lang#100780 (save_analysis: Migrate diagnostic) - rust-lang#100808 (Migrate `rustc_interface` diagnostics ) - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated) - rust-lang#100960 (rustdoc: ayu code color selector more specific) - rust-lang#100964 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.