Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op mobile CSS .sidebar { margin: 0; padding: 0 } #105309

Merged
merged 1 commit into from Dec 6, 2022

Conversation

notriddle
Copy link
Contributor

This isn't overriding anything, because the sidebar never has a margin or padding on it.

This isn't overriding anything, because the sidebar never has a margin or
padding on it.
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2022

Failed to set assignee to CraftSpider: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2022

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 5, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Dec 5, 2022

📌 Commit 65072ee has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
…-padding, r=GuillaumeGomez

rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`

This isn't overriding anything, because the sidebar never has a margin or padding on it.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
…-padding, r=GuillaumeGomez

rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`

This isn't overriding anything, because the sidebar never has a margin or padding on it.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
…-padding, r=GuillaumeGomez

rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`

This isn't overriding anything, because the sidebar never has a margin or padding on it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
Rollup of 10 pull requests

Successful merges:

 - rust-lang#104967 (Fix UI issues with Rustdoc scrape-examples feature.)
 - rust-lang#105207 (interpret: clobber return place when calling function)
 - rust-lang#105246 (Fix --pass in compiletest)
 - rust-lang#105256 (Add small comment explaining what `method-margins.goml` test is about)
 - rust-lang#105289 (Fix dupe word typos)
 - rust-lang#105309 (rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`)
 - rust-lang#105313 (Update books)
 - rust-lang#105315 (Normalize inherent associated types after substitution)
 - rust-lang#105324 (Point at GAT `where` clause when an obligation is unsatisfied)
 - rust-lang#105338 (Tweak "the following other types implement trait")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6dd1a40 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
@notriddle notriddle deleted the notriddle/sidebar-margin-padding branch December 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants