Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #99647 #105994

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Add regression test for #99647 #105994

merged 2 commits into from
Dec 27, 2022

Conversation

JohnTitor
Copy link
Member

Closes #99647
r? @compiler-errors

Signed-off-by: Yuki Okushi jtitor@2k36.org

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 21, 2022
@@ -0,0 +1,16 @@
// edition:2018
// compile-flags: -Zcrate-attr=feature(generic_const_exprs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this doesn't depend on the flag, right? can this be made into a #![feature] instead and moved into like consts/ (i think there's a folder in there for generic const exprs)

Copy link
Member Author

@JohnTitor JohnTitor Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right! I thought it depended on the flag as the issue mentioned it, but code with the #![feature] attr indeed ICE'd on nightly-2022-07-23. Pushed a change: ba8d7cd

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit 66ca5cc has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#105817 (Remove unreasonable help message for auto trait)
 - rust-lang#105994 (Add regression test for rust-lang#99647)
 - rust-lang#106066 (Always suggest as `MachineApplicable` in `recover_intersection_pat`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5b975c into rust-lang:master Dec 27, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 27, 2022
@JohnTitor JohnTitor deleted the issue-99647 branch December 28, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: issue-73050.rs with generic_const_exprs: !value.has_escaping_bound_vars()
4 participants