Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always suggest as MachineApplicable in recover_intersection_pat #106066

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Always suggest as MachineApplicable in recover_intersection_pat #106066

merged 1 commit into from
Dec 27, 2022

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Dec 22, 2022 •
edited
Loading

This resolves one FIXME in recover_intersection_pat by always applying MachineApplicable when suggesting, as bindings_after_at is now stable.
This also separates a test to apply // run-rustfix.

Signed-off-by: Yuki Okushi jtitor@2k36.org

@JohnTitor
Always suggest as MachineApplicable in recover_intersection_pat
668d9fd 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2022

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 22, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit 668d9fd has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned jackh726 Dec 27, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106183 - matthiaskrgr:rollup-ww6yzhi, r=matth…
db79625 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#105817 (Remove unreasonable help message for auto trait)
 - rust-lang#105994 (Add regression test for rust-lang#99647)
 - rust-lang#106066 (Always suggest as `MachineApplicable` in `recover_intersection_pat`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7657e9 into rust-lang:master Dec 27, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 27, 2022
@JohnTitor JohnTitor deleted the rm-bindings-after-at-fixme branch December 28, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnTitor @rustbot @compiler-errors @bors @jackh726