Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote riscv64gc-unknown-linux-musl to tier 2 #122049

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Promote riscv64gc-unknown-linux-musl to tier 2 #122049

wants to merge 1 commit into from
+11 −2

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 5, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 5, 2024
@Amanieu
Copy link
Member Author

Amanieu commented Mar 5, 2024

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@kraj
Copy link
Contributor

kraj commented Mar 5, 2024

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@Amanieu I will be happy to help. Please add me.

kraj
kraj approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Amanieu
Copy link
Member Author

Amanieu commented Mar 5, 2024

I've opened an MCP: rust-lang/compiler-team#728

@Amanieu Amanieu changed the title Promote riscv64gc-unknown-linux-gnu to tier 2 Promote riscv64gc-unknown-linux-musl to tier 2 Mar 6, 2024
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@Mark-Simulacrum
Copy link
Member

This should probably update the platform support docs to indicate the tier 2 target.

@bors
Copy link
Contributor

bors commented Mar 12, 2024

☔ The latest upstream changes (presumably #122170) made this pull request unmergeable. Please resolve the merge conflicts.

@kraj
Copy link
Contributor

kraj commented Mar 12, 2024

☔ The latest upstream changes (presumably #122170) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu this needs a manual rebase and push I guess

@Dylan-DPC Dylan-DPC added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraj kraj kraj approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Amanieu @rustbot @kraj @Mark-Simulacrum @bors @Dylan-DPC