Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crater] Enforce supertrait outlives obligations hold when confirming impl #124336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[crater] Enforce supertrait outlives obligations hold when confirming impl #124336

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

r? @lcnr

Fixes #98117

@compiler-errors
Copy link
Member Author

@bors try

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124336 - compiler-errors:super-outlives, r=<try>
311f8b6 
[crater] Enforce supertrait outlives obligations hold when confirming impl

r? `@lcnr`

Fixes rust-lang#98117
@bors
Copy link
Contributor

bors commented Apr 24, 2024

⌛ Trying commit 26513eb with merge 311f8b6...

@compiler-errors
Copy link
Member Author

TODO: also do this in the new solver

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@compiler-errors
Copy link
Member Author

@craterbot run mode=check-only start=master#5557f8c9d08d7f3f680943dcf97b6d4a7eb13aea end=try#311f8b6ca41358db8ae08490a9ca0916f11e9de3

@craterbot
Copy link
Collaborator

👌 Experiment pr-124336 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-124336 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-124336 is completed!
📊 16 regressed and 3 fixed (442198 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 1, 2024
@apiraino
Copy link
Contributor

apiraino commented Jul 4, 2024

seems the crater run wasnt too happy

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024
@compiler-errors
Copy link
Member Author

@craterbot run mode=check-only start=master#5557f8c9d08d7f3f680943dcf97b6d4a7eb13aea end=try#311f8b6ca41358db8ae08490a9ca0916f11e9de3 crates=https://crater-reports.s3.amazonaws.com/pr-124336/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-124336-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-124336-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-124336-1 is completed!
📊 10 regressed and 0 fixed (16 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsoundness due to where clauses not checked for well-formedness
6 participants
@compiler-errors @bors @craterbot @apiraino @lcnr @rustbot