Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::thread: adding get_name haiku implementation. #123267

Merged
merged 1 commit into from
Mar 31, 2024
Merged

std::thread: adding get_name haiku implementation. #123267

merged 1 commit into from
Mar 31, 2024

Conversation

devnexen
Copy link
Contributor

follow-up #123233

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 31, 2024
joboet
joboet requested changes Mar 31, 2024
View reviewed changes
library/std/src/sys/pal/unix/thread.rs Outdated Show resolved Hide resolved
library/std/src/sys/pal/unix/thread.rs Show resolved Hide resolved
@joboet joboet assigned joboet and unassigned cuviper Mar 31, 2024
@joboet joboet added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
joboet
joboet approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@joboet joboet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get'st thou names of threads,
Then do assign mine name for:
Thine work I do like.

r=me once CI is green

@joboet
Copy link
Contributor

joboet commented Mar 31, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit e5c5ed0 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2024
@workingjubilee workingjubilee mentioned this pull request Mar 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#123299 - workingjubilee:rollup-2z8amaj, r=wor…
8058136 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123180 (Rewrite `core-no-fp-fmt-parse` test in Rust)
 - rust-lang#123267 (std::thread: adding get_name haiku implementation.)
 - rust-lang#123268 (warn against implementing Freeze)
 - rust-lang#123271 (doc: describe panic conditions for SliceIndex implementations)
 - rust-lang#123295 (add myself to compiler review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a08f02 into rust-lang:master Mar 31, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123267
9ad6728 
Rollup merge of rust-lang#123267 - devnexen:thread_get_name_haiku, r=joboet

std::thread: adding get_name haiku implementation.

follow-up rust-lang#123233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joboet joboet joboet approved these changes

Assignees

@joboet joboet

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devnexen @rustbot @joboet @bors @cuviper