Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myself to compiler review rotation #123295

Merged
merged 1 commit into from
Mar 31, 2024
Merged

add myself to compiler review rotation #123295

merged 1 commit into from
Mar 31, 2024

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Mar 31, 2024

title

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues about the rust-lang/rust repository. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit 8d67fb9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@workingjubilee workingjubilee mentioned this pull request Mar 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#123299 - workingjubilee:rollup-2z8amaj, r=wor…
8058136 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123180 (Rewrite `core-no-fp-fmt-parse` test in Rust)
 - rust-lang#123267 (std::thread: adding get_name haiku implementation.)
 - rust-lang#123268 (warn against implementing Freeze)
 - rust-lang#123271 (doc: describe panic conditions for SliceIndex implementations)
 - rust-lang#123295 (add myself to compiler review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7d0a59 into rust-lang:master Mar 31, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123295
da7feef 
Rollup merge of rust-lang#123295 - BoxyUwU:boxy_compiler_reviews, r=Mark-Simulacrum

add myself to compiler review rotation

title
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues about the rust-lang/rust repository. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BoxyUwU @rustbot @Mark-Simulacrum @bors