Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize fn allocator for Rc/Arc. #124980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generalize fn allocator for Rc/Arc. #124980

wants to merge 1 commit into from
+36 −20

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented May 10, 2024

Split out from #119761

  • For Rc/Arc, the existing associated fns are changed to allow unsized pointees.
  • For Weaks, new methods are added.

@rustbot label +A-allocators

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-allocators Area: Custom and system allocators labels May 10, 2024
@zachs18 zachs18 mentioned this pull request May 10, 2024
Closed
@joboet
Copy link
Contributor

joboet commented May 12, 2024

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 12, 2024
@rustbot rustbot assigned m-ou-se and unassigned joboet May 12, 2024
@zachs18 zachs18 mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-allocators Area: Custom and system allocators S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zachs18 @rustbot @joboet @m-ou-se