Skip to content

Allow cargo fix to partially apply mismatched_lifetime_syntaxes #144601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kornelski
Copy link
Contributor

Workaround for #144588 (comment)

Not all suggestions have to be hidden from cargo fix, only redundant ones. The redundant ones are already hidden from the user, so the same tool_only flag can be used to hide them from cargo fix. This way cargo fix will be able to correctly apply the fixes, and will apply only the fix that the compiler visibly suggests to the user.

@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2025
@shepmaster
Copy link
Member

/cc @ehuss. Is this an acceptable alternative fix to #142980 / #142998?

@petrochenkov
Copy link
Contributor

Looks reasonable to me.
r? @ehuss

@rustbot rustbot assigned ehuss and unassigned petrochenkov Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants