Stabilize `strict_overflow_ops` #144682

nxsaken · 2025-07-30T13:53:00Z

rustbot · 2025-07-30T13:53:05Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-30T13:53:08Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

nxsaken · 2025-07-30T19:44:58Z

I see a mention of strict_overflow_ops in src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs, but I'm not sure if I should manually change stuff in a generated directory.

Mark-Simulacrum · 2025-08-03T23:32:21Z

I think it should be ok to edit that file - see e.g. 53c1301 as a prior example.

Mark-Simulacrum · 2025-08-03T23:32:28Z

r=me with that done

rustbot · 2025-08-04T00:13:35Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

nxsaken · 2025-08-04T07:22:25Z

ping @Mark-Simulacrum

Mark-Simulacrum · 2025-08-05T01:32:11Z

@bors r+

bors · 2025-08-05T01:32:14Z

📌 Commit 17241a7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Rollup of 16 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144443 (Make target pointer width in target json an integer) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144682 (Stabilize `strict_overflow_ops`) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144910 (Add regression tests for seemingly fixed issues) - #144926 (Correct the use of `must_use` on btree::IterMut) - #144928 (Drop `rust-version` from `rustc_thread_pool`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) Failed merges: - #144914 (Add support for `ty::Instance` path shortening in diagnostics) r? `@ghost` `@rustbot` modify labels: rollup

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Rollup of 15 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144682 (Stabilize `strict_overflow_ops`) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144910 (Add regression tests for seemingly fixed issues) - #144926 (Correct the use of `must_use` on btree::IterMut) - #144928 (Drop `rust-version` from `rustc_thread_pool`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) r? `@ghost` `@rustbot` modify labels: rollup

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Rollup of 11 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144133 (Stabilize const TypeId::of) - #144676 (Add documentation for unstable_feature_bound) - #144682 (Stabilize `strict_overflow_ops`) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144917 (Enforce tail call type is related to body return type in borrowck) - #144926 (Correct the use of `must_use` on btree::IterMut) - #144928 (Drop `rust-version` from `rustc_thread_pool`) - #144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`) r? `@ghost` `@rustbot` modify labels: rollup

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Rollup of 7 pull requests Successful merges: - #138689 (add nvptx_target_feature) - #140267 (implement continue_ok and break_ok for ControlFlow) - #143807 (Pass -Werror when building the LLVM wrapper) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - #144682 (Stabilize `strict_overflow_ops`) - #145026 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 19 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #138689 (add nvptx_target_feature) - #140267 (implement continue_ok and break_ok for ControlFlow) - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - #144650 (Additional tce tests) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144682 (Stabilize `strict_overflow_ops`) - #145026 (Update books) - #145033 (Reimplement `print_region` in `type_name.rs`.) - #145040 (rustc-dev-guide subtree update) Failed merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144682 - nxsaken:strict_overflow_ops, r=Mark-Simulacrum Stabilize `strict_overflow_ops` Closes #118260

Rollup of 19 pull requests Successful merges: - rust-lang/rust#137831 (Tweak auto trait errors) - rust-lang/rust#138689 (add nvptx_target_feature) - rust-lang/rust#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang/rust#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang/rust#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang/rust#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang/rust#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang/rust#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang/rust#144133 (Stabilize const TypeId::of) - rust-lang/rust#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang/rust#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang/rust#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang/rust#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang/rust#144650 (Additional tce tests) - rust-lang/rust#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang/rust#144682 (Stabilize `strict_overflow_ops`) - rust-lang/rust#145026 (Update books) - rust-lang/rust#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang/rust#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Rollup of 19 pull requests Successful merges: - rust-lang#137831 (Tweak auto trait errors) - rust-lang#138689 (add nvptx_target_feature) - rust-lang#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang#144133 (Stabilize const TypeId::of) - rust-lang#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang#144650 (Additional tce tests) - rust-lang#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang#144682 (Stabilize `strict_overflow_ops`) - rust-lang#145026 (Update books) - rust-lang#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 19 pull requests Successful merges: - rust-lang/rust#137831 (Tweak auto trait errors) - rust-lang/rust#138689 (add nvptx_target_feature) - rust-lang/rust#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang/rust#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang/rust#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang/rust#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang/rust#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang/rust#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang/rust#144133 (Stabilize const TypeId::of) - rust-lang/rust#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang/rust#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang/rust#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang/rust#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang/rust#144650 (Additional tce tests) - rust-lang/rust#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang/rust#144682 (Stabilize `strict_overflow_ops`) - rust-lang/rust#145026 (Update books) - rust-lang/rust#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang/rust#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jul 30, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2025

This comment has been minimized.

Sign in to view

Stabilize strict_overflow_ops

3ff3a1e

nxsaken force-pushed the strict_overflow_ops branch from 54af655 to 3ff3a1e Compare July 30, 2025 19:39

Remove strict_overflow_ops lint

17241a7

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 5, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

c710bb7

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Zalathar mentioned this pull request Aug 5, 2025

Rollup of 16 pull requests #144942

Closed

Kobzol added a commit to Kobzol/rust that referenced this pull request Aug 5, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

828b52e

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

Kobzol mentioned this pull request Aug 5, 2025

Rollup of 15 pull requests #144943

Closed

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 5, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

ba35d74

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 16 pull requests #144951

Closed

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 5, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

8c28284

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 11 pull requests #144952

Closed

tgross35 added a commit to tgross35/rust that referenced this pull request Aug 7, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

76c2577

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

tgross35 mentioned this pull request Aug 7, 2025

Rollup of 7 pull requests #145031

Closed

Zalathar mentioned this pull request Aug 7, 2025

Rollup of 19 pull requests #145043

Merged

bors merged commit 622b21e into rust-lang:master Aug 7, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 7, 2025

rust-timer added a commit that referenced this pull request Aug 7, 2025

Unrolled build for #144682

6dceffe

Rollup merge of #144682 - nxsaken:strict_overflow_ops, r=Mark-Simulacrum Stabilize `strict_overflow_ops` Closes #118260

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 12, 2025

Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…

a43ec7e

…k-Simulacrum Stabilize `strict_overflow_ops` Closes rust-lang#118260

lolbinarycat mentioned this pull request Aug 7, 2025

Tracking Issue for arithmetic that panics on overflow (strict_* operations) #118260

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize `strict_overflow_ops` #144682

Stabilize `strict_overflow_ops` #144682

Uh oh!

nxsaken commented Jul 30, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

This comment has been minimized.

nxsaken commented Jul 30, 2025

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

nxsaken commented Aug 4, 2025

Uh oh!

Mark-Simulacrum commented Aug 5, 2025

Uh oh!

bors commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Stabilize strict_overflow_ops #144682

Stabilize strict_overflow_ops #144682

Uh oh!

Conversation

nxsaken commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

This comment has been minimized.

nxsaken commented Jul 30, 2025

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

nxsaken commented Aug 4, 2025

Uh oh!

Mark-Simulacrum commented Aug 5, 2025

Uh oh!

bors commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Stabilize `strict_overflow_ops` #144682

Stabilize `strict_overflow_ops` #144682

nxsaken commented Jul 30, 2025 •

edited

Loading