fix drop scope for super let bindings within if let
#145342
Open
+155
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They now use the enclosing temporary scope as their scope, regardless of which `ScopeData` was used to mark it.
rustbot
added
S-waiting-on-review
dianne
force-pushed
the
if-let-super-let
branch
from
f7b3d29 to
8fc3938
Compare
traviscross
added
P-lang-drag-1
|
@dianne does this need crater? |
|
@bors2 try |
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 13, 2025
fix drop scope for `super let` bindings within `if let`
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145328 by making non-lifetime-extended
super letreuse the logic used to compute drop scopes for non-lifetime-extended temporaries.Tracking issue for
super let: #139076This is a regression fix / breaking change for macros stably exposing
super let, includingpin!.Nominating to be discussed alongside #145328: @rustbot label +I-lang-nominated +I-libs-api-nominated