Skip to content

Do not enable LLD if we don't build host code for targets that opt into it #147698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Do not enable LLD if we don't build host code for targets that opt into it #147698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/bootstrap/src/core/config/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,15 @@ impl Config {
continue;
}

// The rust.lld option is global, and not target specific, so if we enable it, it will
// be applied to all targets being built.
// So we only apply an override if we're building a compiler/host code for the given
// override target.
// Note: we could also make the LLD config per-target, but that would complicate things
if !hosts.contains(&TargetSelection::from_user(&target)) {
continue;
}

let default_linux_linker_override = match linker_override {
DefaultLinuxLinkerOverride::Off => continue,
DefaultLinuxLinkerOverride::SelfContainedLldCc => {
Expand Down
Loading