Skip to content

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Oct 15, 2025

In 9253e12 a bunch of gdbr-check (for rust-gdb) directives and gdbg-check (for plain gdb) directives were added. But in two places the author accidentally wrote gdbt-check instead (t is next to r on the keyboard). And no one noticed (and cared) for 9 years. This commit fixes that typo.

#129218 later renamed gdbr-check to just gdb-check which is why we rename to gdb-check directly.

The test still passes locally for me after the change, but fails if I change the gdb-check checks to check for some other string, so the check seems to still perform its intended function.

After this there are no more instances of the string gdbt in the code base:

$ git grep gdbt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

…n.rs`

In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) and
`gdbg-check` (for plain `gdb`) was added. But in two places the author
accidentally wrote `gdbt-check` instead. This commit fixes this typo.
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [debuginfo-gdb] tests/debuginfo/function-arg-initialization.rs stdout ----
NOTE: compiletest thinks it is using GDB version 16003000

error: check directive(s) from `/checkout/tests/debuginfo/function-arg-initialization.rs` not found in debugger output. errors:
    (function-arg-initialization.rs:30) `$4 = function_arg_initialization::BigStruct {a: 3, b: 4, c: 5, d: 6, e: 7, f: 8, g: 9, h: 10}`
    (function-arg-initialization.rs:32) `$5 = function_arg_initialization::BigStruct {a: 11, b: 12, c: 13, d: 14, e: 15, f: 16, g: 17, h: 18}`
the following subset of check directive(s) was found successfully:
    (function-arg-initialization.rs:21) `$1 = 1`
    (function-arg-initialization.rs:23) `$2 = true`
    (function-arg-initialization.rs:25) `$3 = 2.5`
    (function-arg-initialization.rs:37) `$6 = 19`
    (function-arg-initialization.rs:39) `$7 = 20`
    (function-arg-initialization.rs:41) `$8 = 21.5`
    (function-arg-initialization.rs:46) `$9 = 22`
    (function-arg-initialization.rs:48) `$10 = 23`
    (function-arg-initialization.rs:50) `$11 = 24.5`
    (function-arg-initialization.rs:55) `$12 = 25`
    (function-arg-initialization.rs:57) `$13 = 26`
    (function-arg-initialization.rs:59) `$14 = 27.5`
    (function-arg-initialization.rs:64) `$15 = 28`
    (function-arg-initialization.rs:66) `$16 = 29`
    (function-arg-initialization.rs:68) `$17 = 30.5`
    (function-arg-initialization.rs:73) `$18 = 31`
    (function-arg-initialization.rs:75) `$19 = 32`
    (function-arg-initialization.rs:77) `$20 = 33.5`
    (function-arg-initialization.rs:82) `$21 = 34`
    (function-arg-initialization.rs:84) `$22 = 35`
    (function-arg-initialization.rs:86) `$23 = 36.5`
    (function-arg-initialization.rs:91) `$24 = 37`
    (function-arg-initialization.rs:93) `$25 = 38`
    (function-arg-initialization.rs:95) `$26 = 39.5`
    (function-arg-initialization.rs:100) `$27 = 40`
    (function-arg-initialization.rs:102) `$28 = 41`
    (function-arg-initialization.rs:104) `$29 = 42`
    (function-arg-initialization.rs:109) `$30 = 43`
    (function-arg-initialization.rs:111) `$31 = 44`
    (function-arg-initialization.rs:113) `$32 = 45`
status: exit status: 0
command: PYTHONPATH="/checkout/src/etc" "/usr/bin/gdb" "-quiet" "-batch" "-nx" "-command=/checkout/obj/build/aarch64-unknown-linux-gnu/test/debuginfo/function-arg-initialization.gdb/function-arg-initialization.debugger.script"
--- stdout -------------------------------
GNU gdb (Ubuntu 16.3-1ubuntu2) 16.3
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "aarch64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
To enable execution of this file add
 add-auto-load-safe-path /checkout/src/etc/gdb_load_rust_pretty_printers.py
line to your configuration file "/home/user/.config/gdb/gdbinit".
To completely disable this security protection add
 set auto-load safe-path /
line to your configuration file "/home/user/.config/gdb/gdbinit".
For more information about this security protection see the
"Auto-loading safe path" section in the GDB manual.  E.g., run from the shell:
 info "(gdb)Auto-loading safe path"
Breakpoint 1 at 0xc7c: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 222.
Breakpoint 2 at 0xcdc: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 237.
Breakpoint 3 at 0xed8: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 241.
Breakpoint 4 at 0xb40: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 246.
Breakpoint 5 at 0xc54: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 251.
Breakpoint 6 at 0xb7c: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 256.
Breakpoint 7 at 0xc34: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 260.
Breakpoint 8 at 0xca4: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 263.
Breakpoint 9 at 0xf24: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 267.
Breakpoint 10 at 0xba4: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 275.
Breakpoint 11 at 0xfa4: file /checkout/tests/debuginfo/function-arg-initialization.rs, line 283.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/aarch64-linux-gnu/libthread_db.so.1".

Breakpoint 1, function_arg_initialization::immediate_args (a=1, b=true, c=2.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:222
222     zzz(); // #break
$1 = 1
$2 = true
$3 = 2.5

Breakpoint 2, function_arg_initialization::non_immediate_args (a=..., b=...) at /checkout/tests/debuginfo/function-arg-initialization.rs:237
237     zzz(); // #break
$4 = <optimized out>
$5 = <optimized out>

Breakpoint 3, function_arg_initialization::binding (a=19, b=20, c=21.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:241
241     let x = 0; // #break
$6 = 19
$7 = 20
$8 = 21.5


Breakpoint 4, function_arg_initialization::assignment (a=22, b=23, c=24.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:246
246     a = b; // #break
$9 = 22
$10 = 23
$11 = 24.5


Breakpoint 5, function_arg_initialization::function_call (x=25, y=26, z=27.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:251
251     zzz(); // #break
$12 = 25
$13 = 26
$14 = 27.5

Breakpoint 6, function_arg_initialization::identifier (x=28, y=29, z=30.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:256
256 }
$15 = 28
$16 = 29
$17 = 30.5

Breakpoint 7, function_arg_initialization::return_expr (x=31, y=32, z=33.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:260
260 }
$18 = 31
$19 = 32
$20 = 33.5

Breakpoint 8, function_arg_initialization::arithmetic_expr (x=34, y=35, z=36.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:263
263     x + y // #break
$21 = 34
$22 = 35
$23 = 36.5

Breakpoint 9, function_arg_initialization::if_expr (x=37, y=38, z=39.5) at /checkout/tests/debuginfo/function-arg-initialization.rs:267
267     if x + y < 1000 { // #break
$24 = 37
$25 = 38
$26 = 39.5

Breakpoint 10, function_arg_initialization::while_expr (x=40, y=41, z=42) at /checkout/tests/debuginfo/function-arg-initialization.rs:275
275     while x + y > 1000 { // #break
$27 = 40
$28 = 41
$29 = 42

Breakpoint 11, function_arg_initialization::loop_expr (x=43, y=44, z=45) at /checkout/tests/debuginfo/function-arg-initialization.rs:283
283         x += z; // #break
$30 = 43
$31 = 44
$32 = 45

Breakpoint 11, function_arg_initialization::loop_expr (x=88, y=44, z=45) at /checkout/tests/debuginfo/function-arg-initialization.rs:283
283         x += z; // #break
A debugging session is active.

 Inferior 1 [process 232948] will be killed.

Quit anyway? (y or n) [answered Y; input not from terminal]
------------------------------------------
--- stderr -------------------------------
warning: File "/checkout/src/etc/gdb_load_rust_pretty_printers.py" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load".
------------------------------------------

---- [debuginfo-gdb] tests/debuginfo/function-arg-initialization.rs stdout end ----

failures:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants