Skip to content

Don't highlight let expressions as having type bool in let-chain error messages #147738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Don't highlight let expressions as having type bool in let-chain error messages #147738

merged 1 commit into from
Oct 16, 2025
+19 −1

Conversation

pommicket
Copy link
Contributor

@pommicket pommicket commented Oct 15, 2025 •
edited by rustbot
Loading

Fixes #147665.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
madsmtm
madsmtm approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@madsmtm madsmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracing back a bit, this diagnostic was introduced in #105192, which is before let chains, so it's reasonable to assume that it wasn't taken into account then.

The fix looks simple enough that I'm comfortable approving it even though I'm not that well-versed in this part of the codebase, thanks!

@bors r+ rollup

View changes since this review

@madsmtm
Copy link
Contributor

madsmtm commented Oct 16, 2025

@bors ping

@bors
Copy link
Collaborator

bors commented Oct 16, 2025

😪 I'm awake I'm awake

@madsmtm
Copy link
Contributor

madsmtm commented Oct 16, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 16, 2025

📌 Commit 984542c has been approved by madsmtm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#147738 - pommicket:issue-147665, r=madsmtm
28b216e 
Don't highlight `let` expressions as having type `bool` in let-chain error messages

Addresses rust-lang#147665.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2025
Closed
bors added a commit that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147765 - matthiaskrgr:rollup-kkwiczz, r=matthiaskrgr
7b46301 
Rollup of 7 pull requests

Successful merges:

 - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce)
 - #147000 (std: Add Motor OS std library port)
 - #147732 (remove duplicate inline macro)
 - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages)
 - #147744 (miri subtree update)
 - #147751 (Use `bit_set::Word` in a couple more places.)
 - #147752 (style-guide: fix typo for empty struct advice)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#147738 - pommicket:issue-147665, r=madsmtm
df39c99 
Don't highlight `let` expressions as having type `bool` in let-chain error messages

Addresses rust-lang#147665.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#147738 - pommicket:issue-147665, r=madsmtm
058d105 
Don't highlight `let` expressions as having type `bool` in let-chain error messages

Addresses rust-lang#147665.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#147738 - pommicket:issue-147665, r=madsmtm
61c4323 
Don't highlight `let` expressions as having type `bool` in let-chain error messages

Addresses rust-lang#147665.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#147738 - pommicket:issue-147665, r=madsmtm
19c6fea 
Don't highlight `let` expressions as having type `bool` in let-chain error messages

Addresses rust-lang#147665.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2025
Closed
bors added a commit that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147775 - matthiaskrgr:rollup-u90jv4x, r=matthiaskrgr
5a87bc0 
Rollup of 7 pull requests

Successful merges:

 - #147000 (std: Add Motor OS std library port)
 - #147732 (remove duplicate inline macro)
 - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages)
 - #147739 (Fix whitespace in rustfmt-excluded clippy file)
 - #147744 (miri subtree update)
 - #147751 (Use `bit_set::Word` in a couple more places.)
 - #147752 (style-guide: fix typo for empty struct advice)

r? `@ghost`
`@rustbot` modify labels: rollup
@chenyukang
Copy link
Member

chenyukang commented Oct 16, 2025 •
edited
Loading

Thanks!
I updated the PR description to use Fixes link the issue.

bors added a commit that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147775 - matthiaskrgr:rollup-u90jv4x, r=matthiaskrgr
c721120 
Rollup of 7 pull requests

Successful merges:

 - #147000 (std: Add Motor OS std library port)
 - #147732 (remove duplicate inline macro)
 - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages)
 - #147739 (Fix whitespace in rustfmt-excluded clippy file)
 - #147744 (miri subtree update)
 - #147751 (Use `bit_set::Word` in a couple more places.)
 - #147752 (style-guide: fix typo for empty struct advice)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2025
Merged
bors added a commit that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147782 - matthiaskrgr:rollup-9728xqu, r=matthiaskrgr
53a741f 
Rollup of 9 pull requests

Successful merges:

 - #144438 (Guard HIR lowered contracts with `contract_checks`)
 - #147000 (std: Add Motor OS std library port)
 - #147576 (Fix ICE on offsetted ZST pointer)
 - #147732 (remove duplicate inline macro)
 - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages)
 - #147744 (miri subtree update)
 - #147751 (Use `bit_set::Word` in a couple more places.)
 - #147752 (style-guide: fix typo for empty struct advice)
 - #147773 (`is_ascii` on an empty string or slice returns true)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d8dd468 into rust-lang:master Oct 16, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 16, 2025
rust-timer added a commit that referenced this pull request Oct 16, 2025
@rust-timer
Unrolled build for #147738
43a3b3a 
Rollup merge of #147738 - pommicket:issue-147665, r=madsmtm

Don't highlight `let` expressions as having type `bool` in let-chain error messages

Fixes #147665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees

@madsmtm madsmtm

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

Diagnostics say that the let in let chains has type bool

5 participants

@pommicket @rustbot @madsmtm @bors @chenyukang