implement replace_with and replacen_with for unstable feature replace_with
#147741
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
4 tasks
Kivooeo
reviewed
Oct 16, 2025
Comment on lines
+346
to
+356
| if let Some(from_byte) = match from.as_utf8_pattern() { | ||
| Some(Utf8Pattern::StringPattern([from_byte])) => Some(*from_byte), | ||
| Some(Utf8Pattern::CharPattern(c)) => c.as_ascii().map(|ascii_char| ascii_char.to_u8()), | ||
| _ => None, | ||
| } { | ||
| if let Some(sref) = from_byte.as_ascii().map(|ascii_char| f(ascii_char.as_str())) { | ||
| if let [to_byte] = sref.as_ref().as_bytes() { | ||
| return unsafe { replace_ascii(self.as_bytes(), from_byte, *to_byte) }; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Would it be possible to use let chains here?
There was a problem hiding this comment.
Updated with an if-let chain, did you have something else in mind or is this fine? (f70b5e1)
This comment has been minimized.
This comment has been minimized.
|
Hm, that's weird because alloc is 2024 edition Line 11 in f524236 |
|
It does compile with edition 2021 anyway tho Well, I guess that's fine to revert this then :) If this ever will get 2024 edition I will cleanup this accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for the tracking issue #147731 for implementation of
replace_with.