Fix ICE from invalid delimeter in attrs parsing #147778
Open
+81
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
chenyukang
force-pushed
the
yukang-fix-ice-146808-attr
branch
from
6a86737 to
6400ed6
Compare
|
r? jdonszelmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146808
I tried hard to get the correct span, but didn't come out with a great result. I think maybe it's better to report an error when expand macro failing for contract:
rust/compiler/rustc_builtin_macros/src/contracts.rs
Line 50 in f524236