-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Implement VecDeque::extract_if #147780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tisonkun
wants to merge
5
commits into
rust-lang:master
Choose a base branch
from
tisonkun:vec-deque-extract-if
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement VecDeque::extract_if #147780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f120ac2
to
6f38bda
Compare
This comment has been minimized.
This comment has been minimized.
6f38bda
to
1d182aa
Compare
This comment has been minimized.
This comment has been minimized.
1d182aa
to
238229b
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
238229b
to
9cba3ed
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
This is now ready for review. I'm trying to port some tests from LinkedList's extract_if cases. |
This comment has been minimized.
This comment has been minimized.
c42dc3b
to
ff878de
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
ff878de
to
2915a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to #147750.