Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Oct 17, 2025

r? @jieyouxu

Unfortunately this doesn't work for all tests; minicore sometimes fails to build with errors like

rustc-LLVM ERROR: ILP32E cannot be used with the D ISA extension

and

error: the target features paca, pacg must all be either enabled or disabled together

These errors are meant to be triggered in the tests, but not in minicore.

It seems like all @compile-flags are forwarded to minicore. Maybe we should exclude -Ctarget-feature from that? Or provide some way to set flags only for the current file, not minicore?

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung RalfJung changed the title use minicore for target-feature tests use minicore for more tests Oct 17, 2025
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [ui] tests/ui/target-feature/abi-incompatible-target-feature-flag-enable.rs#riscv stdout ----

error in revision `riscv`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 101
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "riscv" "--check-cfg" "cfg(test,FALSE,x86,riscv)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/abi-incompatible-target-feature-flag-enable.riscv/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=lib" "--target=riscv32e-unknown-none-elf" "-Ctarget-feature=+d" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: target feature `d` must be disabled to ensure that the ABI of the current target can be implemented correctly
   |
   = note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #116344 <https://github.com/rust-lang/rust/issues/116344>

warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

warning: unstable feature specified for `-Ctarget-feature`: `d`
   |
   = note: this feature is not stably supported; its behavior can change in the future

rustc-LLVM ERROR: ILP32E cannot be used with the D ISA extension
------------------------------------------

---- [ui] tests/ui/target-feature/abi-incompatible-target-feature-flag-enable.rs#riscv stdout end ----
---- [ui] tests/ui/target-feature/tied-features-cli.rs#one stdout ----

error in revision `one`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "one" "--check-cfg" "cfg(test,FALSE,one,two,three,four)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-cli.one/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-C" "target-feature=+paca" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-cli.rs#one stdout end ----
---- [ui] tests/ui/target-feature/tied-features-cli.rs#two stdout ----

error in revision `two`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "two" "--check-cfg" "cfg(test,FALSE,one,two,three,four)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-cli.two/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-C" "target-feature=-pacg,+pacg" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-cli.rs#two stdout end ----
---- [ui] tests/ui/target-feature/tied-features-cli.rs#three stdout ----

error in revision `three`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "three" "--check-cfg" "cfg(test,FALSE,one,two,three,four)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-cli.three/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-C" "target-feature=+paca,+pacg,-paca" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-cli.rs#three stdout end ----
---- [ui] tests/ui/target-feature/tied-features-no-implication-1.rs#paca stdout ----

error in revision `paca`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "paca" "--check-cfg" "cfg(test,FALSE,paca,pacg)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-no-implication-1.paca/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-Ctarget-feature=+paca" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-no-implication-1.rs#paca stdout end ----
---- [ui] tests/ui/target-feature/tied-features-no-implication-1.rs#pacg stdout ----

error in revision `pacg`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "pacg" "--check-cfg" "cfg(test,FALSE,paca,pacg)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-no-implication-1.pacg/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-Ctarget-feature=+pacg" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-no-implication-1.rs#pacg stdout end ----
---- [ui] tests/ui/target-feature/tied-features-no-implication.rs#paca stdout ----

error in revision `paca`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "paca" "--check-cfg" "cfg(test,FALSE,paca,pacg)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-no-implication.paca/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-Ctarget-feature=+paca" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-no-implication.rs#paca stdout end ----
---- [ui] tests/ui/target-feature/tied-features-no-implication.rs#pacg stdout ----

error in revision `pacg`: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--cfg" "pacg" "--check-cfg" "cfg(test,FALSE,paca,pacg)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/target-feature/tied-features-no-implication.pacg/libminicore.rlib" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--crate-type=rlib" "--target=aarch64-unknown-linux-gnu" "-Ctarget-feature=+pacg" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
warning: type `c_void` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:238:10
   |
LL | pub enum c_void {
   |          ^^^^^^ help: convert the identifier to upper camel case: `CVoid`
   |
   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default

warning: variant `__variant1` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:239:5
   |
LL |     __variant1,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant1`

warning: variant `__variant2` should have an upper camel case name
##[warning]  --> /checkout/tests/auxiliary/minicore.rs:240:5
   |
LL |     __variant2,
   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `Variant2`

error: the target features paca, pacg must all be either enabled or disabled together

error: aborting due to 1 previous error; 3 warnings emitted
------------------------------------------

---- [ui] tests/ui/target-feature/tied-features-no-implication.rs#pacg stdout end ----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants