Change the tidy license checker #147843
Change the tidy license checker #147843
Conversation
It is more permissive than Apache-2.0 which is already allowed.
With this the only remaining license exceptions are for licenses that are to copyleft to varying degrees.
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
rustbot
added
A-tidy
|
r? @clubby789 rustbot has assigned @clubby789. Use |
src/tools/tidy/src/deps.rs
Outdated
| "Apache-2.0 OR MIT", | ||
| "Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT", // wasi license | ||
| "Apache-2.0 WITH LLVM-exception", | ||
| "Apache-2.0", |
There was a problem hiding this comment.
I'm surprised we allow bare Apache-2.0 for the runtime. This was added in a dependency update PR over a year ago.
There was a problem hiding this comment.
Likewise; I'd like to know where this is used, and if we could avoid it.
There was a problem hiding this comment.
Looks like it isn't used for the runtime, only for tools. I've pushed a commit to move all licenses that are not like MIT to the tools-only license list.
4 participants
This adds a bunch of licenses to the global list of allowed licenses that are at least as permissive as some other license in the list. In addition it adds another list for licenses that are allowed to be used by tools, but not by the runtime. All permissive licenses from the exception lists are added here. This makes it clearer what actual exceptions to our permissive licensing policy are and will hopefully make it a bit easier to review future changes to the list of licenses rather than just adding whatever license is necessary to the global list of allowed licenses or to the list of exceptions.