Skip to content

Conversation

reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Oct 18, 2025

Closes #134355

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 0c2e7ce has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@lqd
Copy link
Member

lqd commented Oct 18, 2025

We have a very similar test already, and I guess that's why the crashtest was removed instead of renamed. The ICE was already fixed, so this does close issue #134355.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
bors added a commit that referenced this pull request Oct 18, 2025
Rollup of 8 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146167 (Deny-by-default never type lints)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 19, 2025
Rollup of 7 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54c6939 into rust-lang:master Oct 19, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Oct 19, 2025
Rollup merge of #147845 - reddevilmidzy:ice-bug, r=jdonszelmann

Add regression test for 134355

Closes #134355
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
@reddevilmidzy reddevilmidzy deleted the ice-bug branch October 19, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: internal compiler error: coercion error but no error emitted

5 participants