Skip to content

Conversation

fee1-dead
Copy link
Member

Previously, this was greedily stolen by the fn parsing logic.

r? project-const-traits

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

No reviewers could be found from initial request project-const-traits
This repo may be misconfigured.
Use r? to specify someone else to assign.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Previously, this was greedily stolen by the `fn` parsing logic.
@fmease
Copy link
Member

fmease commented Oct 19, 2025

r? fmease

@rustbot rustbot assigned fmease and unassigned madsmtm Oct 19, 2025
@fmease
Copy link
Member

fmease commented Oct 19, 2025

cc #146122

@fee1-dead
Copy link
Member Author

I quite agree with your comment at #146122 (comment)

@fmease
Copy link
Member

fmease commented Oct 19, 2025

Thanks! This is good enough for now. I'm already experimenting with more robust qualifier parsing in a separate project of mine.

Once stage0 rustfmt is bumped we can finally migrate away from the remaining #[const_trait]s in library/ that were left because of this bug.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

📌 Commit b145213 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants