Skip to content

Rollup of 3 pull requests #147892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 20, 2025
Merged

Rollup of 3 pull requests #147892

merged 6 commits into from
Oct 20, 2025

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 19, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

devnexen and others added 6 commits October 19, 2025 05:50
@devnexen
std::thread::available_parallelism() vxworks libc symbol usage.
4333e72
@Zalathar
Include a file path in DirectiveLine
37a0e62 
This avoids the need to laboriously pass a test/aux file path into dozens of
directive parsing methods that already take a `DirectiveLine`.
@jieyouxu
triagebot: remind to update rustc-dev-guide docs when modifying compi…
860a3d4 
…letest directives
@Zalathar
Rollup merge of rust-lang#147870 - devnexen:vxworks_simpl_cpu_detect,…
6cb0a55 
… r=joboet

`std::thread::available_parallelism()` vxworks libc symbol usage.
@Zalathar
Rollup merge of rust-lang#147879 - Zalathar:directive, r=jieyouxu
905b9da 
compiletest: Include a file path in `DirectiveLine`

This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a `DirectiveLine`.

r? jieyouxu
@Zalathar
Rollup merge of rust-lang#147880 - jieyouxu:advise-directive-docs, r=…
fc2f6dd 
…fmease

Add a triagebot reminder to update rustc-dev-guide docs when modifying compiletest directives
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 19, 2025
@Zalathar
Copy link
Contributor Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

📌 Commit fc2f6dd has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
@Zalathar
Copy link
Contributor Author

Rollup of everything.

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

⌛ Testing commit fc2f6dd with merge c0c37ca...

@Zalathar Zalathar mentioned this pull request Oct 20, 2025
Closed
@bors
Copy link
Collaborator

bors commented Oct 20, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing c0c37ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 20, 2025
@bors bors merged commit c0c37ca into rust-lang:master Oct 20, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 20, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#147870 std::thread::available_parallelism() vxworks libc symbol … 7994bd5c1b363c653906d601198c72199e6f006b (link)
#147879 compiletest: Include a file path in DirectiveLine 263b677dc9afb6c0b4c28eb518676229613c629e (link)
#147880 Add a triagebot reminder to update rustc-dev-guide docs whe… 9a8bad7dab086839c278148c27d4987475a575a4 (link)

previous master: f04e3dfc87

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@Zalathar Zalathar deleted the rollup-kfcbfex branch October 20, 2025 02:51
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f04e3df (parent) -> c0c37ca (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c0c37cafdcf74a8c8b53fe19c85d546c57437e98 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-android: 1521.2s -> 1132.7s (-25.5%)
  2. dist-apple-various: 4268.0s -> 3549.9s (-16.8%)
  3. dist-x86_64-apple: 5979.7s -> 6853.7s (14.6%)
  4. dist-aarch64-apple: 6105.4s -> 6989.4s (14.5%)
  5. dist-various-1: 3790.9s -> 4198.5s (10.8%)
  6. dist-ohos-armv7: 4034.9s -> 4413.2s (9.4%)
  7. dist-ohos-aarch64: 4284.8s -> 4630.4s (8.1%)
  8. aarch64-msvc-2: 4835.7s -> 5201.0s (7.6%)
  9. dist-i586-gnu-i586-i686-musl: 5316.8s -> 4921.1s (-7.4%)
  10. dist-x86_64-windows-gnullvm: 4772.8s -> 5123.4s (7.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c0c37ca): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.871s -> 471.783s (-0.44%)
Artifact size: 388.68 MiB -> 388.66 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar @bors @rust-timer @rustbot @devnexen @jieyouxu