Skip to content

Conversation

Zalathar
Copy link
Contributor

There seem to be a few UI tests that use environment variable TARGET to avoid problems on i586, but we should probably just permit and use //@ ignore-i586 instead.

The run-make runner explicitly sets TARGET on its own, so run-make tests shouldn't be affected.

This PR is currently just for running try jobs; it's not intended for merging (yet).

r? ghost

@Zalathar Zalathar added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 20, 2025
@Zalathar
Copy link
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 20, 2025
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests

try-job: dist-i586-gnu-i586-i686-musl
@Zalathar Zalathar removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 20, 2025

☀️ Try build successful (CI)
Build commit: 0bf5ba8 (0bf5ba8b452dcbef660253c1594cbd22ffffeaf1, parent: f04e3dfc87d7e2b6ad53e7a52253812cd62eba50)

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar
Copy link
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

rust-bors bot added a commit that referenced this pull request Oct 20, 2025
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests

try-job: dist-i586-gnu-i586-i686-musl
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Zalathar
Copy link
Contributor Author

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Oct 20, 2025

Try build cancelled. Cancelled workflows:

@Zalathar
Copy link
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

rust-bors bot added a commit that referenced this pull request Oct 20, 2025
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests

try-job: dist-i586-gnu-i586-i686-musl
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 20, 2025

💔 Test for 1f51c82 failed: CI. Failed jobs:

@Zalathar
Copy link
Contributor Author

OK, this confirms that i586 still requires special treatment to avoid breaking CI.

But we should be able to just use //@ ignore-i586 for that.

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Building test helpers for aarch64-unknown-linux-gnu
##[endgroup]
[TIMING:end] test::TestHelpers { target: aarch64-unknown-linux-gnu } -- 0.059
##[group]Testing stage2 with compiletest suite=ui mode=ui (aarch64-unknown-linux-gnu)
2025-10-20T07:27:53.060061Z ERROR compiletest::directives: /checkout/tests/ui/abi/homogenous-floats-target-feature-mixup.rs:10: invalid line: ignore-i586 (no SSE2)
2025-10-20T07:27:53.169400Z ERROR compiletest::directives: /checkout/tests/ui/target-feature/target-feature-detection.rs:5: invalid line: ignore-i586 (no SSE2)


thread 'main' (24437) panicked at src/tools/compiletest/src/lib.rs:650:9:
there are errors in tests
stack backtrace:

There are a few tests that were trying to skip i586 targets via the `TARGET`
environment variable instead, so better to just add support for the directive.
@Zalathar
Copy link
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

rust-bors bot added a commit that referenced this pull request Oct 20, 2025
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests

try-job: dist-i586-gnu-i586-i686-musl
@rust-bors
Copy link

rust-bors bot commented Oct 20, 2025

⌛ Trying commit 9347126 with merge 4bedb6d

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/18646956085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants