Skip to content

Conversation

maplethecolor
Copy link

@maplethecolor maplethecolor commented Oct 20, 2025

Fixes #147889
The PR doesn't exactly match the original issue (w.r.t the second suggestion), so please provide input on which option is better. :)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
diff of stderr:

- error[E0118]: no nominal type found for inherent implementation
-   --> $DIR/wrong-normalization.rs:16:1
+ error: expected one of `#`, `>`, `const`, identifier, or lifetime, found `{`
+   --> $DIR/wrong-normalization.rs:16:10
3    |
4 LL | impl <I8<{i8::MIN}> as Identity>::Identity {
-    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ impl requires a nominal type
-    |
-    = note: either implement a trait on it or create a newtype to wrap it instead
+    |          ^ expected one of `#`, `>`, `const`, identifier, or lifetime
8 
9 error: aborting due to 1 previous error
10 

- For more information about this error, try `rustc --explain E0118`.
12 

Note: some mismatched output was normalized before being compared
-   --> /checkout/tests/ui/const-generics/wrong-normalization.rs:16:10
+ error: expected one of `#`, `>`, `const`, identifier, or lifetime, found `{`
+   --> $DIR/wrong-normalization.rs:16:10
+    |          ^ expected one of `#`, `>`, `const`, identifier, or lifetime


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args const-generics/wrong-normalization.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/const-generics/wrong-normalization.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/const-generics/wrong-normalization" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error: expected one of `#`, `>`, `const`, identifier, or lifetime, found `{`
##[error]  --> /checkout/tests/ui/const-generics/wrong-normalization.rs:16:10
   |
LL | impl <I8<{i8::MIN}> as Identity>::Identity {
   |          ^ expected one of `#`, `>`, `const`, identifier, or lifetime

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/const-generics/wrong-normalization.rs stdout end ----

@maplethecolor maplethecolor marked this pull request as draft October 20, 2025 11:55
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bare type in impl parameter list causes non-intuitive parse error

4 participants