Fix ICE in rustdoc when impl is nested in a func #147911
Open
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases like
hir_enclosing_body_owner()
in rustdoc consideredfn foo()
to be the “enclosing body” ofE
, which caused to to produceHirId
s forE
with owner set tofn foo()
instead of the impl. This instead treatsE
as having no enclosing body.r? @GuillaumeGomez as the author of this logic, I’m not 100% I understood it correctly.
Fixes #147882.
Fixes #147057.